pwm improvements #304
Closed
pwm improvements #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-add capability to change pwm signal frequency with analogWriteFrequency -improve pwm signal frequency accuracy
|
@eriknyquist @SidLeung ready for review |
eriknyquist
reviewed
Sep 29, 2016
| @@ -47,7 +49,7 @@ extern void analogReference( eAnalogReference ulMode ) ; | |||
| * \param pin | |||
| * \param val | |||
| */ | |||
| extern void analogWrite( uint8_t pin, int val ) ; | |||
| extern void analogWrite( uint8_t pin, uint32_t val ) ; | |||
There was a problem hiding this comment.
Is this required (changing the API)? Assuming we're still just looking for a positive integer, can you leave the analogWrite declaration as it was, and instead cast to uint32_t as needed?
| * | ||
| * \param res | ||
| */ | ||
| extern void analogWriteFrequency(uint8_t pin, uint32_t freq); |
There was a problem hiding this comment.
would recommend using int for both pin and freq, if possible-- just more Arduino-y :)
|
+1 |
|
@bigdinotech ready for merging? |
|
@eriknyquist still needs to be tested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-add capability to change pwm signal frequency with analogWriteFrequency
-improve pwm signal frequency accuracy