Make g_APinDescription const #308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has the effect of moving g_APinDescription out of .data (SRAM), and into .rodata (flash). Pros: sketches now have an additional 1160 bytes of SRAM available Cons: state of pins is no longer tracked; e.g. when calling digitalWrite, the full configuration is done each time. See changes in wiring_digital.c and wiring_analog.c for details. There is inevitably a performance impact for digitalRead/Write & analogRead/Write, though it is unlikely to be a noticable one.
bigdinotech
approved these changes
Oct 3, 2016
|
Internal BAT Tests were ran using tT and 101 boards no issues. +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has the effect of moving g_APinDescription out of .data (SRAM),
and into .rodata (flash).
Pros:
sketches now have an additional 1160 bytes of SRAM available
Cons:
state of pins is no longer tracked; e.g. when calling digitalWrite,
the full configuration is done each time. See changes in wiring_digital.c
and wiring_analog.c for details. There is inevitably a performance impact
for digitalRead/Write & analogRead/Write, though it is unlikely to be a
noticable one.
@calvinatintel @bigdinotech @SidLeung @russmcinnis @noelpaz please review.
Do not merge until it is explicitly requested