Don't save unstripped elf for debugging #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current save mechanism breaks when a user has deleted system32 from PATH environment variable. Comment out the copying so that it won't break for such users, but do not delete so that advanced users can use the unstripped elfs to debug.
calvinatintel
added a commit
to calvinatintel/CODK-A-ARC
that referenced
this pull request
Oct 7, 2016
Debug elf saving was disabled in order to make IDE more fool proof arduino/ArduinoCore-arc32#314 This commit re-enables the elf saving so that it'll work on make debug-* targets.
facchinm
approved these changes
Oct 7, 2016
eriknyquist
approved these changes
Oct 7, 2016
calvinatintel
added a commit
to calvinatintel/CODK-A
that referenced
this pull request
Oct 11, 2016
Debug elf saving was disabled in order to make IDE more idiot proof arduino/ArduinoCore-arc32#314 This commit re-enables the elf saving to make debug-* targets work again
calvinatintel
added a commit
to calvinatintel/CODK-A
that referenced
this pull request
Oct 12, 2016
Debug elf saving was disabled in order to make IDE more idiot proof arduino/ArduinoCore-arc32#314 This commit re-enables the elf saving to make debug-* targets work again
calvinatintel
added a commit
to calvinatintel/CODK-A
that referenced
this pull request
Oct 12, 2016
Debug elf saving was disabled in order to make IDE more idiot proof arduino/ArduinoCore-arc32#314 This commit re-enables the elf saving to make debug-* targets work again
calvinatintel
added a commit
to calvinatintel/CODK-A
that referenced
this pull request
Oct 12, 2016
Debug elf saving was disabled in order to make IDE more idiot proof arduino/ArduinoCore-arc32#314 This commit re-enables the elf saving to make debug-* targets work again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current save mechanism breaks when a user has deleted system32 from PATH environment variable. Comment out the copying so that it won't break for such users, but do not delete so that advanced users can use the unstripped elfs to debug.