Add functions to check if new IMU data is available #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
accelDataReady() and gyroDataReady() read the drdy_acc and drdy_gyr bits, respectively, of the BMI160's sensor status register. This removes the burden of syncronising sensor reads from the user. (adapted from descampsa/corelibs-arduino101@773a800)
|
Now that we're using the "All Issues" and "All PRs" with "Assigned" filters, can you please assign the ticket to me if you need me to test or merge? Thanks |
|
Why is this "DataReady" when the Arduino style guide requires "available"? |
|
Well, because I didn't implement an 'available' function. There's no buffering going on, just wrappers for reading the DRDY bits of the BMI160 status reg. |
|
@PaulStoffregen are you conceding? gonna merge this unless you have major issues with it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
accelDataReady() and gyroDataReady() read the drdy_acc and drdy_gyr
bits, respectively, of the BMI160's sensor status register. This removes
the burden of syncronising sensor reads from the user.
(adapted from descampsa/corelibs-arduino101@773a800)
@bigdinotech @calvinatintel @SidLeung please review.
Don't merge this. I'm gonna do some testing and I'll merge it when that's done.