Skip to content

Use SAMD21 serial number for USB serial number prefix #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 23, 2017

Conversation

sandeepmistry
Copy link
Contributor

This is based on section 9.3.3 of the data sheet.

With this change, Blink is 1948 bytes larger on a MKR1000 (without change 9256 bytes, with change 11204 bytes).

Anyone know of a slimmer way to convert a register value to a hex string?

@sandeepmistry
Copy link
Contributor Author

I've made things slimmer using something based on utoa with leading zero padding and upper case conversion.

Blink on a MKR1000 is now 9760 bytes, without the patch it's 9256 bytes - so now a 504 byte increase.

@arduino arduino deleted a comment from ArduinoBot Aug 3, 2017
@sandeepmistry
Copy link
Contributor Author

Even simpler now with @cmaglie's suggestion, now Blink is down to 9336 bytes, so just an 80 byte increase!

@ArduinoBot
Copy link

✅ Build completed.

⬇️ Build URL: http://downloads.arduino.cc/PR/samd/package_samd-b158_index.json

ℹ️ To test this build:

  1. Open the Preferences of the Arduino IDE.
  2. Add the Build URL above in the Additional Boards Manager URLs field, and click OK.
  3. Open the Boards Manager (menu Tools->Board->Board Manager...)
  4. Install Arduino SAMD core - Pull Request Use SAMD21 serial number for USB serial number prefix #252
  5. Select one of the boards under SAMD Pull Request Use SAMD21 serial number for USB serial number prefix #252 in Tools->Board menu
  6. Compile/Upload as usual

@arduino arduino deleted a comment from ArduinoBot Aug 4, 2017
@cmaglie cmaglie merged commit 0ee6248 into arduino:master Aug 23, 2017
@cmaglie cmaglie added this to the Release 1.6.16 milestone Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants