Minor testing improvements #145
Conversation
|
✅ Build completed. ⬇️ Build URL: ℹ️ To test this build:
|
| ``` | ||
|
|
||
| In jenkins, use | ||
| ``` | ||
| go test -timeout 60m -v ./src/arduino.cc/builder/test/... | bin/go-junit-report > report.xml | ||
| go test -v arduino.cc/builder/test | bin/go-junit-report > report.xml |
There was a problem hiding this comment.
Well this timeout has been added not much for the initial download of tools but mainly for the ARM release: running the test natively on a Raspberry PI2 takes about 30 minutes. So probably it's best to keep it as default?
There was a problem hiding this comment.
Right. Still, I'd like to keep the default commandline as short as possible, so that people can actually remember it and type it quickly, without having to copy-paste from the README every time. In any case, I'll add a note to the README about the ARM build.
|
I added a note about ARM slowness to the README. |
|
❌ Build failed. |
These are created automatically when their contents is actually downloaded during testing, so there is no need to keep empty directories in git. By removing them it is possible to share the same directories between multiple git working trees, by simply making symlinks (which was not possible before without ending up with a modified working tree). Signed-off-by: Matthijs Kooijman <[email protected]>
This more verbosely explains what the -v and -timeout options are for (and removes them from the default command shown). Also, this adds info on how to run a single test. Signed-off-by: Matthijs Kooijman <[email protected]>
In commit 7520e66 (Removed no more used "coan" tools), one tool was removed, but these testcases were not updated accordingly. This commit updates the testcases with the correct number of tools to expect. While here, the testcases are expanded to also explicitely check the name and version number for all tools. This makes the test more complete, but also documents what tools and versions are expected exactly, which makes it easier to diagnose problems like this one later. Also, instead of using hardcoded array indices, this converts the latter two testcases to use an idx variable, just like the first testcase. This makes it easier to insert a new tool later. Signed-off-by: Matthijs Kooijman <[email protected]>
|
Rebased on top of master, let's see if that fixes the ArduinoBot build. |
|
✅ Build completed. ⬇️ Build URL: ℹ️ To test this build:
|
This makes it a bit easier to share downloaded files between multiple working trees, and improves the document for running tests a bit.