linker: allow multi-step link recipe (c.combine)
#2954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recipes must follow the 'prefix.NNN.suffix' pattern, where 'NNN' is a number. When there is also a single 'prefix.suffix' property defined, make sure to not include that in the list of recipes to run. However, if no numbered recipes are found, use the single 'prefix.suffix' form if it exists. This allows to have both a single recipe and a set of numbered recipes in the same build properties, for backwards compatibility. Signed-off-by: Luca Burelli <[email protected]>
Enable the use of recipes for the `recipe.c.combine.pattern` command. Allows for more flexibility in the build process. Signed-off-by: Luca Burelli <[email protected]>
pillo79
changed the title
c.combine)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2954 +/- ##
==========================================
+ Coverage 68.01% 68.04% +0.03%
==========================================
Files 239 239
Lines 22589 22592 +3
==========================================
+ Hits 15363 15372 +9
+ Misses 6023 6019 -4
+ Partials 1203 1201 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
per1234
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the possibility of using multiple commands for the
c.combinepattern, and infrastructure that will enable using the same logic on any build step, if so decided.Two changes in behavior are introduced:
When looking for multi-step recipes (e.g. hooks) in
RunRecipe(), a key that exactly matchesprefix.suffixis explicitly ignored if numbered entries are found, and only used as a fallback when no other entries are present.This change is consistent with current docs that require a
prefix.NNN.suffixsyntax for multi-step recipes. A property namedprefix.suffixis undefined behavior, and is currently included among the numbered ones.Reuse the
RunRecipelogic for therecipe.c.combinestep to allow multi-stage linking. The above change in this context means that numbered steps have priority over the single property, but both can be specified to maintain backwards compatibility (the new numbered properties are ignored by the current IDE).NO TESTS as I don't know where to add the test case... 😇 BUT I tried with a core that defined these rules and got the exact behavior I described here. If someone can give me pointers I can add the proper test case.
Feel free to cherry-pick and/or edit and/or shoot down at will 😅