"Failed to start language server" error when IDE installation path contains `#`

[Wezz19]

Describe the problem

• No splashscreen at start
• Language server fails to start
• The text in the editor has no colors (probably caused by the language server)

The IDE is otherwise working. Verify, upload and serial monitor works normally.

To reproduce

Place a '#' in the IDE folder name and start the IDE.

Expected behavior

If '#' in the IDE folder name can't be supported in Windows due to limited support in other OS's then a notification to the user should make it clear that the IDE folder name contains an unsupported symbol.

Otherwise since the IDE seems to be running normally except for the language server then maybe it can be fixed to support '#' symbols in windows at least.

Arduino IDE version

nightly-20220628

Operating system

Windows

Operating system version

10

Additional context

2022-06-28 11:53:12 root INFO [d044d6a1-4348-4d71-813b-f0efe4e7ed33] Start of 0 plugins: 203.1 ms [Finished 3.714 s after frontend start]
2022-06-28 11:53:12 root INFO Starting language server: arduino:avr:uno
2022-06-28 11:53:12 root INFO Failed to start language server for arduino:avr:uno
2022-06-28 11:53:12 root INFO Starting language server: arduino:avr:uno
2022-06-28 11:53:12 root INFO Failed to start language server for arduino:avr:uno
2022-06-28 11:53:12 root INFO Starting language server: arduino:avr:uno
2022-06-28 11:53:12 root INFO Failed to start language server for arduino:avr:uno
2022-06-28 11:53:12 root INFO Starting language server: arduino:avr:uno
2022-06-28 11:53:12 root INFO Failed to start language server for arduino:avr:uno
2022-06-28 11:53:12 root INFO Starting language server: arduino:avr:uno
2022-06-28 11:53:12 root INFO Failed to start language server for arduino:avr:uno
2022-06-28 11:53:12 root INFO Starting language server: arduino:avr:uno
2022-06-28 11:53:12 root INFO Failed to start language server for arduino:avr:uno
2022-06-28 11:53:13 root INFO Frontend application start: 2637.1 ms [Finished 6.808 s after backend start]

Issue checklist

• I searched for previous reports in the issue tracker
• I verified the problem still occurs when using the latest nightly build
• My report contains all necessary details

[per1234]

Thanks for your report @Wezz19. I am able to reproduce the issue when using the Arduino IDE from such a path, but didn't have any problems when running Arduino Language Server directly from the command line with equivalent parameters. So this leads me to believe the issue is here in the Arduino IDE 2.x code base rather than in the Arduino Language Server code base.

[kittaakos]

• The text in the editor has no colors (probably caused by the language server)

No. Syntax coloring is done by TextMate and is unrelated to any language features.

[r3inbowari]

This is caused by the theia-core module with incorrect assertion on Windows when the plugins path has a ‘#’.

[kittaakos]

Great instructions, thanks!

it can be fixed to support '#' symbols in windows at least.

It's not a Windows-specific problem. I can reproduce it on macOS.

This is caused by the theia-core module with incorrect assertion on Windows when the plugins path has a ‘#’.

There may be a different reason.

1. From the logs, I can see that the Arduino VS Code extension starts:

PluginDeployerEntryImpl {
    originId: 'local-dir:../plugins',
    pluginId: 'vscode-arduino-tools',
    _type: 0,
    map: Map(1) { 'package.json' => [Object] },
    changes: [ 'PluginVsCodeDirectoryHandler' ],
    acceptedTypes: [ 1 ],
    currentPath: '/Users/a.kitta/dev/git/arduino-ide/plugins/vscode-arduino-tools/extension',
    initPath: '/Users/a.kitta/dev/git/arduino-ide/plugins/vscode-arduino-tools',
    resolved: true,
    resolvedByName: 'LocalDirectoryPluginDeployerResolver',
    _rootPath: '/Users/a.kitta/dev/git/arduino-ide/plugins/vscode-arduino-tools'
  },

2. I also see the Building Sketch in the status bar when I edit the sketch in the editor. The status bar update comes from the Arduino language-server.
3. The LS log files were generated as expected. Use "arduino.language.log": true in the settings.json and check the log files. You can even tail them.

1124.mp4

The LS works in other source files:

1124_02.mp4

[kittaakos]

From the LS logs:

{"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"uri":"file:///private/var/folders/z1/xkw1yh5n7rz4n8djprp1mdn80000gn/T/arduino-language-server4280496927/.clangd","diagnostics":[]}}Content-Length: 178

{"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"uri":"file:///Users/a.kitta/Documents/Arduino/alma%23korte/alma%23korte.ino","version":1,"diagnostics":[]}}Content-Length: 112

{"jsonrpc":"2.0","id":1,"result":null,"error":{"code":-32603,"message":"-32001 Line value is out of range (2)"}}Content-Length: 36

This bug might belong to another issue tracker.

[kittaakos]

I can also see that the URI is incorrectly encoded. Maybe @cmaglie can advise:

V[08:48:25.483] ASTWorker running EnumerateTweaks on version 1 of /private/var/folders/z1/xkw1yh5n7rz4n8djprp1mdn80000gn/T/arduino-language-server4280496927/sketch/alma#korte.ino.cpp
I[08:48:25.483] --> reply:textDocument/codeAction("2") 86 ms, error: Line value is out of range (2)
V[08:48:25.483] >>> {"error":{"code":-32001,"message":"Line value is out of range (2)"},"id":"2","jsonrpc":"2.0"}

V[08:48:25.484] <<< {"id":"3","jsonrpc":"2.0","method":"textDocument/documentSymbol","params":{"textDocument":{"uri":"file:///private/var/folders/z1/xkw1yh5n7rz4n8djprp1mdn80000gn/T/arduino-language-server4280496927/sketch/alma#korte.ino.cpp"}}}

Here the URI must be

file:///private/var/folders/z1/xkw1yh5n7rz4n8djprp1mdn80000gn/T/arduino-language-server4280496927/sketch/alma%23korte.ino.cpp

and NOT

file:///private/var/folders/z1/xkw1yh5n7rz4n8djprp1mdn80000gn/T/arduino-language-server4280496927/sketch/alma#korte.ino.cpp