Skip to content

fix(actions): generic action had exit and init reversed #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2021
Merged

fix(actions): generic action had exit and init reversed #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Assets/FluidBehaviorTree/Runtime/Tasks/Actions/ActionGeneric.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ protected override void OnStart () {
}

protected override void OnExit () {
initLogic?.Invoke();
exitLogic?.Invoke();
}

protected override void OnInit () {
exitLogic?.Invoke();
initLogic?.Invoke();
}
}
}
}
15 changes: 14 additions & 1 deletion Assets/FluidBehaviorTree/Tests/Editor/Tasks/Actions/ActionGenericTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,19 @@ public void It_should_execute_a_init_hook () {
Assert.AreEqual(1, test);
}

[Test]
public void It_should_execute_init_hook_on_continue () {
var test = 0;
var task = new ActionGeneric {
initLogic = () => { test++; },
updateLogic = () => TaskStatus.Continue,
};

task.Update();

Assert.AreEqual(1, test);
}

[Test]
public void It_should_execute_a_exit_hook () {
var test = 0;
Expand All @@ -57,4 +70,4 @@ public void It_should_execute_a_exit_hook () {
}
}
}
}
}