Unquoted TagHelper attribute values with `=` in their value cause Debug.Assert failure.

[NTaylorMullen]

If we have a TagHelper.

<myth name=something=value key="@value" />

You get a debug assert here.

[dougbu]

@NTaylorMullen your example is invalid. Is this about catching the HTML syntax violation earlier?

The HTML 5 spec says unquoted attribute values:

must not contain any literal space characters, any U+0022 QUOTATION MARK characters ("), U+0027 APOSTROPHE characters ('), "=" (U+003D) characters, "<" (U+003C) characters, ">" (U+003E) characters, or U+0060 GRAVE ACCENT characters (`), and must not be the empty string.

[NTaylorMullen]

@dougbu It's definitely invalid, however it shouldn't crash the parser 😄. Instead of Debug.Asserting we should be logging an error to the ErrorSink.

[dougbu]

Well, it won't crash the parser in release mode 😈

Thanks for the clarification.