This repository was archived by the owner on Apr 6, 2018. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #568 - instead of trying to emulate VIM's undo grouping (described here and here) and running into difficulties trying to cover all the ways change groups should be interrupted (see #568), this one relies on Atom undo grouping, and attempts to join delete operations with subsequent typing.
Limitation: if you type
3sabc<escape>
, Atom will separate the undo of the deletion of three characters by3s
and the addition ofa
. I have a solution in mind, a tentative PR for atom/text-buffer is in preparation.@bronson - you commented on the desirability of #568 - can you please review this one?