fifo-sns-sqs-lambda-firehose-s3: Update runtime to python3.12 #2811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakakakakku
commented
Aug 2, 2025
| @@ -6,7 +6,7 @@ terraform { | |||
| required_providers { | |||
| aws = { | |||
| source = "hashicorp/aws" | |||
| version = "~> 4.0" | |||
| version = "~> 5.0" | |||
There was a problem hiding this comment.
note: Older version does not support Python 3.12 runtime. So I updated the version to v5.
| bucket = aws_s3_bucket.bucket.id | ||
| acl = "private" | ||
| } | ||
|
|
There was a problem hiding this comment.
note: The following error occurred when applying.
╷
│ Error: creating S3 Bucket (fifo-sns-sqs-lambda-firehose-s3-bucket-5b7433b3) ACL: operation error S3: PutBucketAcl, https response error StatusCode: 400, RequestID: EK11E0X70MEFY6FR, HostID: gP6Dqkaj45f3GylF7d94XhcAlriiDAFaQfNPbhgDEGaE0OulEyFHUfKHPDBLaJw+DpFQWo9+QvdjAhyJqXk+KE6Nc3ERu4p0Nc24CepIuQQ=, api error AccessControlListNotSupported: The bucket does not allow ACLs
│
│ with module.aws_s3_bucket.aws_s3_bucket_acl.acl,
│ on modules/terraform-aws-s3/main.tf line 16, in resource "aws_s3_bucket_acl" "acl":
│ 16: resource "aws_s3_bucket_acl" "acl" {
│
╵
This issue is related to the changes described in the following blog post. To fix this, I deleted aws_s3_bucket_acl😀
Disabling ACLs is an S3 security best practice, and in April of 2023, we disabled ACLs by default for all new buckets.
https://aws.amazon.com/jp/blogs/storage/disabling-acls-for-existing-amazon-s3-workloads-with-information-in-s3-server-access-logs-and-aws-cloudtrail/
| role_arn = aws_iam_role.firehose_role.arn | ||
| bucket_arn = var.bucket_arn | ||
| buffering_size = var.buffer_size != null ? var.buffer_size : 1 | ||
| buffering_interval = var.buffer_interval != null ? var.buffer_interval : 60 |
There was a problem hiding this comment.
note: Update s3_configuration args for AWS Provider v5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Hi😀 Thanks for the useful patterns!
To prevent future deployment issues, I updated the Lambda Python runtime version to
python3.12.While testing
fifo-sns-sqs-lambda-firehose-s3, I noticed that the Lambda runtime versionpython3.8was deprecated. Although it's still deployable at the moment, it will not be allowed after October 1, 2025.https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html
Check
terraform applycompleted successfully and works good.Thank you😀
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.