Prevent fallback vnodes' solrqs from stopping if they are still needed #703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, we used the "current and next" vnode list according to the ring to determine which partitions were needed for solrq start/stop. This change simply asks `riak_core_vnode_manager` which `riak_kv_vnode` vnodes are currently running, and uses that list to figure out which queues we need to have running. This should prevent issues where fallback vnodes currently running on a node would create many short-lived solrqs, which would start on demand when an index call was made that needed them, and stop every tick.
|
Thanks @JeetKunDoug! Settings---
minimum_reviewers: 2
build_steps:
- make clean
- make test
- make xref
- make dialyzer
merge: false
org_mode: true
timeout: 1790 |
There seems to be an issue with build step **make_test,make_xref,make_dialyzer** ! ☁️
|
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we used the "current and next" vnode list according to the ring
to determine which partitions were needed for solrq start/stop. This
change simply asks
riak_core_vnode_managerwhichriak_kv_vnodevnodes are currently running, and uses that list to figure out which
queues we need to have running.
This should prevent issues where fallback vnodes currently running on a
node would create many short-lived solrqs, which would start on demand
when an index call was made that needed them, and stop every tick.