Support `properties` + `anyOf` together

[bradzacher]

#229 and #167 both proposed this, but were closed even though it is not supported - the workaround in #167 was to change the schema, which I can't do because I don't control the schemas.

{
  type: 'object',
  properties: {
    a: { type: 'string' },
    b: { type: 'number' }
  },
  anyOf: [
    { required: ['a'] },
    { required: ['b'] }
  ]
}

Should produce:

type T = 
  | {
    a: string,
    b?: number,
  }
  | {
    a?: string,
    b: number,
  }

[awlayton]

Changing the schema is also not a good workaround for me.

[awlayton]

It's a bit like cheating, but could this not be solved with a normalizer rule for anyOf/allOf etc. which merges the base schema into all of the subschemas given to the boolean logic keyword?

As in, the above example would get normalized to this:

{
  type: 'object',
  properties: {
    a: { type: 'string' },
    b: { type: 'number' }
  },
  anyOf: [
    {
      type: 'object',
      properties: {
        a: { type: 'string' },
        b: { type: 'number' }
      },
      required: ['a']
    },
    {
      type: 'object',
      properties: {
        a: { type: 'string' },
        b: { type: 'number' }
      },
      required: ['b']
    },
  ]
}

[awlayton]

My idea produces the desired output:

/* tslint:disable */
/**
 * This file was automatically generated by json-schema-to-typescript.
 * DO NOT MODIFY IT BY HAND. Instead, modify the source JSONSchema file,
 * and run json-schema-to-typescript to regenerate this file.
 */

export type Foo =
  | {
      a: string;
      b?: number;
      [k: string]: unknown;
    }
  | {
      a?: string;
      b: number;
      [k: string]: unknown;
    };

I could write a normalizer for this and make a PR, but only you're willing to merge this idea in.

[carlosvfernandez]

I'm having the same problem... any fix/response?

[bcherny]

Quick update: I've been working on this in my spare time. It needs a bit more work before landing, to get the tests to pass: 2163b89

[bcherny]

Fixed in 4aabd23, shipping as part of v10.