New Direct Message endpoint needs to be implemented

[melyux]

Twitter deprecated the old direct message endpoints on September 17, 2018 (3 days ago) after warning about it in July. (see this link: https://twittercommunity.com/t/details-and-what-to-expect-from-the-api-deprecations-this-week-on-august-16-2018/110746)

Does Python Twitter yet support the new endpoints for it? (https://developer.twitter.com/en/docs/direct-messages/sending-and-receiving/guides/direct-message-migration)

Using the PostDirectMessage function right now results in "Sorry, that page does not exist." error 34 from Twitter.

[webtweakers]

I'm having the same issue, found the same cause, was looking for the same reason...

[at0m1sk]

#579

There is a pull request that seems to integrate new endpoint. Request is from Aug 2018.

[spacecab07]

Any idea on when this might get resolved?

[jmingtan]

Yes the version in the pull request is working for us. There are breaking changes to the function though, which is forced by Twitter's changes in the new direct message endpoint. Probably the biggest change is that screen name is no longer supported as a parameter, so we need to call api.GetUser first to get the user id.

[ganmedia]

Any news about this? When will the pull request be integrated?

[bear]

i'll look at this now

[jeremylow]

added everything and fixed up the tests, changed the docs a few hours ago to the 4.0 dev branch. sorry, been out of commission lately :( Jeremy Low JeremyLow@gmail.com

…

On Sat, Sep 29, 2018 at 5:37 PM Mike Taylor ***@***.***> wrote: i'll look at this now — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#587 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEucDWtagR6WM3-VTyrImGfKGK0R3Lk6ks5uf-gzgaJpZM4WxZXS> .

[bear]

@jeremylow do you want me to merge this to the master and bump the version to 3.6 since it's fixing a broken twitter?

[jeremylow]

I was thinking a major version bump, since we have to deprecate a bunch of endpoints, but I can do 3.6 too. I'm not married to either option.

…

On Sat, Sep 29, 2018 at 5:44 PM Mike Taylor ***@***.***> wrote: @jeremylow <https://github.com/jeremylow> do you want me to merge this to the master and bump the version to 3.6 since it's fixing a broken twitter? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#587 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEucDaidk8I6qyzMcIauAcZ9pca5l60Pks5uf-nFgaJpZM4WxZXS> .

[bear]

@jeremylow I think I can make the method signature stay the same to reduce the impact - if screen_name is nil then make the call, if not use it

ok, i'll merge the PR and see if that fixes things

[bear]

I think I have it working and i've tagged a pre-release for v3.5

Can you all give this a go and see if it works - i'll hold off pushing this to PyPI until someone sanity checks it

[webtweakers]

Thanks for picking this up. I've checked the v3.5 release and now things work again, as expected! Looking good from my side.

[ganmedia]

Version 3.5 checked and everything working with no problems.
Great job.

[jeremylow]

Good to go from me!

[kennethdamica]

PostDirectMessage works for me now, but I'm still getting error 34 for GetDirectMessages and GetSentDirectMessages. Looks like these endpoints have been collapsed into "GET direct_messages/events/list". Is this supposed to work in 3.5?