Fatal Compile Error: Declaration of Http\Client\Socket\Stream::close() must be compatible

[Rid]

Unless I use "psr/http-message": "1.1" in composer.json, I get the error:

Declaration of Http\Client\Socket\Stream::close() must be compatible

Looks related to: php-http/socket-client#69

Can anyone reproduce? If so we might need to update our composer.json

[flavioheleno]

Got to reproduce the error.

By reading the issue and related discussions, we may need to replace php-http/socket-client with relevant PSR interfaces - at least PSR18 -, and suggest one or more implementations.

[Rid]

I'm personally already using https://github.com/guzzle/guzzle which also has socket support.

Are there any other suggestions?

[flavioheleno]

I'd suggest Guzzle as well and maybe symfony/http-client, but any of the packages that provide psr/http-client-implementation should be ok as long as they provide unix socket support.

Shall we move with this:

in docker-php-api:

1. Remove nyholm/psr7 under require;
2. Remove php-http/socket-client under suggest
3. Add psr/http-client-implementation under require;
4. Add psr/http-factory-implementation under require;
5. Add psr/http-message-implementation under require.

in docker-php:

1. Replace php-http/socket-client with psr/http-client-implementation;
2. Remove php-http/client-common;
3. Replace nyholm/psr7 with psr/http-message-implementation;
4. Remove php-http/httplug-bundle under suggest;
5. Add guzzlehttp/guzzle under suggest.

Those changes will leave the actual implementation of the underlying transport (HTTP) to the project using docker-php and docker-php-api and no longer force any packages, but suggest guzzlehttp/guzzle as a viable implementation.

[Rid]

@flavioheleno All looks good to me 👍

[flavioheleno]

Done in beluga-php/docker-php#6c0fcd4 and beluga-php/docker-php-api#8a95e39