Skip to content
This repository was archived by the owner on Feb 7, 2024. It is now read-only.

Fix for dependency upgrade #223

Merged
merged 3 commits into from
Jul 28, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Console/StartWebSocketServer.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
use Clue\React\Buzz\Browser;
use Illuminate\Console\Command;
use React\Dns\Config\Config as DnsConfig;
use React\Dns\Resolver\ResolverInterface;
use React\EventLoop\Factory as LoopFactory;
use React\Dns\Resolver\Factory as DnsFactory;
use React\Dns\Resolver\Resolver as ReactDnsResolver;
use BeyondCode\LaravelWebSockets\Statistics\DnsResolver;
use BeyondCode\LaravelWebSockets\Facades\StatisticsLogger;
use BeyondCode\LaravelWebSockets\Facades\WebSocketsRouter;
Expand Down Expand Up @@ -135,7 +135,7 @@ protected function startWebSocketServer()
->run();
}

protected function getDnsResolver(): ReactDnsResolver
protected function getDnsResolver(): ResolverInterface
{
if (! config('websockets.statistics.perform_dns_lookup')) {
return new DnsResolver;
Expand Down
23 changes: 20 additions & 3 deletions src/Statistics/DnsResolver.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,13 @@

namespace BeyondCode\LaravelWebSockets\Statistics;

use React\Dns\Resolver\Resolver;
use React\Promise\FulfilledPromise;
use React\Dns\Resolver\ResolverInterface;

class DnsResolver extends Resolver
class DnsResolver implements ResolverInterface
{
private $internalIP = '127.0.0.1';

/*
* This empty constructor is needed so we don't have to setup the parent's dependencies.
*/
Expand All @@ -17,6 +19,21 @@ public function __construct()

public function resolve($domain)
{
return new FulfilledPromise('127.0.0.1');
return $this->resolveInternal($domain);
}

public function resolveAll($domain, $type)
{
return $this->resolveInternal($domain, $type);
}

private function resolveInternal($domain, $type = null)
{
return new FulfilledPromise($this->internalIP);
}

public function __toString()
{
return $this->internalIP;
}
}