This repository was archived by the owner on Feb 7, 2024. It is now read-only.
[fix] Check for key app on authorization #626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unless I'm mistaken, this only checks in the statistics modules? |
|
@lovetoast It's a middleware that's used in sending events. |
|
@rennokki I thought so, but I tested it and it still allowed the request through, so I also just put a die() in this function and it still allowed it through, there must be somewhere else? |
Merry Christmas! I tried this again, but pretty sure it is not the write place, and I was not able to find the correct place for the APP KEY code. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does better by searching for a key instead of a secret.
Closes #622