Skip to content
This repository was archived by the owner on Feb 7, 2024. It is now read-only.

[fix] Fix stale data #633

Merged
merged 6 commits into from
Dec 7, 2020
Merged

[fix] Fix stale data #633

merged 6 commits into from
Dec 7, 2020

Conversation

rennokki
Copy link
Collaborator

@rennokki rennokki commented Dec 7, 2020

This PR will be addressed to any stale data that was previously found on production environments, as well as the ones related to stale data still present in Redis, like #508 (comment)

Trace resetting

Trace resetting is a way of saying "do not store an array key in-memory/in-database for this app because no activity was recently found". Trace resetting will take care to stop making data points if there was no activity, instead of making data points with 0 values.

Stale data

Stale data is being present because of the hard shutdowns of the app. If there are any connections that get hard deleted without being able to close all the connections in a soft manner, we can end up with stored members into Redis, but without active connections existent.

Also:

  • Fixed a bug where peak connections were staling to a specific value, creating infinite data points (8d1369e)

@rennokki rennokki changed the base branch from master to 2.x December 7, 2020 21:23
@codecov-io
Copy link

codecov-io commented Dec 7, 2020

Codecov Report

Merging #633 (2d30edb) into 2.x (19ca49a) will increase coverage by 0.06%.
The diff coverage is 91.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x     #633      +/-   ##
============================================
+ Coverage     90.13%   90.20%   +0.06%     
  Complexity        2        2              
============================================
  Files            60       60              
  Lines          1582     1592      +10     
============================================
+ Hits           1426     1436      +10     
  Misses          156      156              
Impacted Files Coverage Δ Complexity Δ
src/Statistics/Collectors/RedisCollector.php 97.76% <75.00%> (+0.05%) 0.00 <0.00> (ø)
src/Statistics/Collectors/MemoryCollector.php 97.43% <100.00%> (+0.37%) 0.00 <0.00> (ø)
src/Statistics/Statistic.php 100.00% <100.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19ca49a...2d30edb. Read the comment docs.

@rennokki rennokki merged commit de7e358 into 2.x Dec 7, 2020
@rennokki rennokki deleted the fix/fix-stale-data branch December 7, 2020 22:41
@rennokki rennokki mentioned this pull request Dec 8, 2020
14 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants