Implement "insert type definition of outer function under cursor". #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Thanks, it might take me a while to look over this. If I don't reply here again withing a few weeks then please feel free to remind me about this by commenting/pinging me here |
annaluiseblume
force-pushed
the
master
branch
2 times, most recently
from
4c555f9 to
6b169ba
Compare
Implement the function hdevtools#insert_type() which inserts the type signature of the top level variable or operator at the cursor. The type signature is inserted right above the definition of top level variable or operator.
|
That's a cool feature. Pinging you as suggested @bitc :) |
|
@annaluiseblume I'm testing that branch and having issues. It uses build_command_bare, which ignores my hdevtools_options. If I change that call, I get an error that seems to pertain to an empty list, where l:type_lines[0] results in a `list index out of range:0. I'll leave it at that - sorry not to dig further, I don't know vimscript. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a function hdevtools#insert_type() which inserts the type definition of the outer function under the cursor. The definition is inserted right above the definition of the function.
The functions first gets the number of the first line of the outer function via the last line of output of
hdevtools type <file> <line of cursor> <column of cursor>This line number is then used to find the identifier of the function. The type is then determined via
hdevtools info <file> <identifier>