Feat: add iterable_merge function

[jdecool]

Add iterable_merge function.

[codecov]

Codecov Report

Merging #45 (085c417) into master (95571ed) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #45   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines           44        59   +15     
=========================================
+ Hits            44        59   +15     

Impacted Files	Coverage Δ
src/IterableObject.php	100.00% <100.00%> (ø)
src/iterable-functions.php	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[bpolaszek]

Hi @jdecool,

Thanks for your contribution & sorry for the late reply!

The following case does not succeed:

$array1 = ['bar', 'baz'];
$array2 = ['bat', 'baz'];
$generator1 = fn () => yield from $array1;
$generator2 = fn () => yield from $array2;

expect(iterable_merge($generator1(), $generator2())->asArray())->toEqual(array_merge($array1, $array2));

[jdecool]

No problem @bpolaszek

I've just pushed some updates.

[bpolaszek]

Sounds good to me 🙂

Can you please fix CI + advertise it in README.md?

Thanks! 🙏

[jdecool]

Can you please fix CI + advertise it in README.md?

Sure, everything should be OK now.

[jdecool]

😮 it fails.

Sorry i’ve missed one check

[jdecool]

Everything is fine now is the CI 😌

[bpolaszek]

Thanks @jdecool, your contribution is very much appreciated! 👍

[simPod]

BTW I think this template will not work for merging iterables with different value types.

Also it seems, there's no support for typing it properly phpstan/phpstan#3814 (comment)

[JoshuaBehrens]

Nice feature :)