errors in docs and poorly chosen default for PoolConfig.maxLifetimeSeconds

[mutsys]

the docs state:

  // number of milliseconds a client must sit idle in the pool and not be checked out
  // before it is disconnected from the backend and discarded
  // default is 10000 (10 seconds) - set to 0 to disable auto-disconnection of idle clients
  idleTimeoutMillis?: number

however, the actual default value is 0:

line 92 in pg-pool/index.js

    this.options.maxLifetimeSeconds = this.options.maxLifetimeSeconds || 0

very frustrating. the default configuration for pg-pool results in no pooling whatsoever. acquiring a connection always returns a new, freshly created connection that is immediately discarded once it is released. 0 is not a sensible default. 10 seconds doesn't seem like a sensible default either.

[sehrope]

You're looking at two different parameters:

• idleTimeoutMillis - How long to keep a connection in the pool that is not being used. This is how many milliseconds since it was last used so an inactive pool will eventually evict its connections. The default is 1000 (ten seconds): https://github.com/brianc/node-postgres/blob/54eb0fa216aaccd727765641e7d1cf5da2bc483d/packages/pg-pool/index.js#L98C1-L99C1
• maxLifetimeSeconds - How long to keep a connection in in the pool since creation. This compares the current time vs. the initial creation time of the connection. It's a max overall life for the connection. A value of 60 seconds would evict connections that have been around for over 60-seconds, regardless of whether they are idle. It's useful to force rotation of connection pools through middleware so that you can rotate the underlying servers. The default is disable (value of zero):

  node-postgres/packages/pg-pool/index.js

  Line 92 in 54eb0fa

  this.options.maxLifetimeSeconds = this.options.maxLifetimeSeconds || 0