-
Notifications
You must be signed in to change notification settings - Fork 24
feat: prometheus metrics #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rator into feat/prometheus-metrics
cbartz
reviewed
Jun 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
github-runner-manager/src/github_runner_manager/manager/runner_manager.py
Outdated
Show resolved
Hide resolved
github-runner-manager/src/github_runner_manager/manager/runner_scaler.py
Outdated
Show resolved
Hide resolved
yhaliaw
approved these changes
Jun 30, 2025
cbartz
reviewed
Jun 30, 2025
github-runner-manager/src/github_runner_manager/manager/runner_manager.py
Outdated
Show resolved
Hide resolved
cbartz
approved these changes
Jun 30, 2025
dd94d0c
to
f53e31e
Compare
Test results for commit 6ae9a0dTest coverage for 6ae9a0d
Static code analysis report
|
TICS Quality Gate✔️ Passedgithub-runner-operatorAll conditions passedSee the results in the TICS Viewer The following files have been checked for this project
|
We decided to remove the integration test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable spec:
Overview
** Note that the metrics were requested without refactoring which may lead to inconsistent or faulty metrics, due to the nature of the structure of the code. Any faulty metrics are NOT part of the responsibility of this PR.
Rationale
Juju Events Changes
Module Changes
Library Changes
Checklist
urgent
,trivial
,complex
).