Skip to content
This repository was archived by the owner on Oct 3, 2023. It is now read-only.
This repository was archived by the owner on Oct 3, 2023. It is now read-only.

Stop assuming zonal cluster deployment #292

@MontyCarter

Description

@MontyCarter

zone, err := metadataapi.Zone()

This code works when a GKE cluster is zonally deployed, but is incorrect when run against a regional cluster. With a regional cluster, the Location should be the region name, not the underlying zone name.

This needs to use metadataapi.InstanceAttributeValue("cluster-location") (similar to here: https://github.com/knative/pkg/blob/7d1b0f19ef717da9e0df0ce1e35e1ca81627445f/metrics/gcp_metadata.go#L44)

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions