Skip to content

[WIP] QR codes and symmetric encryption for broadcast channels #7042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 58 commits into
base: main
Choose a base branch
from
Open

[WIP] QR codes and symmetric encryption for broadcast channels #7042

wants to merge 58 commits into from

Conversation

Hocuri
Copy link
Collaborator

@Hocuri Hocuri commented Jul 25, 2025

Alternative attempt at channels encryption to #6995

See #6884 (comment) for explanation on the two possible attempts

@Hocuri Hocuri changed the title Channels encryption with QR codes that directly contain the secret [WIP] Channels encryption with QR codes that directly contain the secret Jul 28, 2025
This was referenced Jul 28, 2025
Closed
Open
@Hocuri Hocuri force-pushed the hoc/channels-encryption-only-qrcodes branch from 322bf0c to abc4e12 Compare August 1, 2025 14:46
@Hocuri Hocuri changed the title [WIP] Channels encryption with QR codes that directly contain the secret [WIP] Symmetrically encrypted broadcast channels Aug 11, 2025
@Hocuri Hocuri force-pushed the hoc/channels-encryption-only-qrcodes branch 2 times, most recently from 983d050 to e4e7a36 Compare August 12, 2025 13:55
Hocuri added 23 commits August 12, 2025 15:59
@Hocuri
feat: Symmetric encryption. No decryption, no sharing of the secret, …
3e11991 
…not tested.
@Hocuri
WIP: Start with decryption, and a test for it. Next TODO: SQL table m…
c99ab4f 
…igartion.
@Hocuri
feat: Save the secret to encrypt and decrypt messages. Next: Send it …
04c8023 
…in a 'member added' message.
@Hocuri
feat: Add create_broadcast_shared_secret()
c1d1bf7
@Hocuri
sync broadcast secret for multidevice
3aa227b
@Hocuri
Make it compile
7c6b52b
@Hocuri
feat: Store symmetric key non-redundantly in the database
2a2b54a
@Hocuri
feat: Add broadcast QR type (todo: documentation)
461aa26
@Hocuri
Adapt the rest of the code to the new QR code type
5c61e04
@Hocuri
test: Add test_send_avatar_in_securejoin
9390cfc
@Hocuri
Broadcast-securejoin is working!!
810df62
@Hocuri
fix: make test_broadcast work, return an error when trying to add man…
34ebfbb 
…ually add a contact to a broadcast list, don't have unpromoted broadcast lists, make basic multi-device, inviter side, work
@Hocuri
Make basic multi-device work on joiner side, fix test_only_minimal_da…
eeece9e 
…ta_are_forwarded
@Hocuri
fix: Make syncing of QR tokens work, make test_sync_broadcast pass
dda48a7
@Hocuri
make test_block_broadcast pass
98b4cad
@Hocuri
test: Fix test_broadcast_multidev
ab52eac
@Hocuri
test: Fix one panic in test_broadcasts_name_and_avatar, but there is …
dc2c912 
…another one where I couldn't find the problem
@Hocuri
fix: Make joining a channel work with multi-device, fix test_leave_br…
55b3a7f 
…oadcast_multidevice
@Hocuri
test: fix test_leave_broadcast
f790e9f
@Hocuri
test: fix test_encrypt_decrypt_broadcast()
e8e9ddd
@Hocuri
fix: Actually send broadcast message to recipients, ALL TESTS PASS NO…
86a7b68 
…W - fix test_broadcasts_name_and_avatar().
@Hocuri
Add TODO
e241af9
@Hocuri
fix: Let Alice send vb-member-added so that the chat is immediately s…
99b24d4 
…hown on Bob's device
Hocuri added 25 commits August 12, 2025 15:59
@Hocuri
WIP, untested: Sending side of transferring the secret in member-adde…
a74d706 
…d message
@Hocuri
WIP, untested: Receiving side of passing broadcast secret in a message
abb1d41
@Hocuri
feat: Transfer the broadcast secret in an encrypted message rather th…
73d0dc2 
…an directly in the QR code
@Hocuri
Don't include the broadcast's shared secret in the QR code
e63429f
@Hocuri
refactor: Use the same decode_name() function for the contact name, r…
21afbf9 
…emove redundant check for grpid.is_some()

If grpid is none, the group/brodacast name isn't used, anyways
@Hocuri
refactor: It's not actually necessary for Alice to remember how the m…
63cdf7e 
…essage was encrypted
@Hocuri
clippy
7f3f4d5
@Hocuri
test: Improve test_send_avatar_in_securejoin()
d1769ed
@Hocuri
No clippy warnings anymore!
af52772
@Hocuri
Use translatable message for broadcast-joining
6bf5e87
@Hocuri
Add golden test that only one member-added message is shown for Bob
c513afa
@Hocuri
fix: Show only one member-added message for Bob
c5731f7
@Hocuri
docs: Fix wrong comment on msg_del_member_local()
494cd39
@Hocuri
Notify a removed member that they were removed
44ae964
@Hocuri
Remove unnecessary TODO
f321ed2
@Hocuri
fix: Don't show a weird 'Secure-Join: vb-request-v2 message' in Alice…
209ad44 
…'s 1:1 chat a recipient
@Hocuri
comments/naming: Make sure that I consistently use shared_secret
8a8ce8d
@Hocuri
fix: Make sure that only the channel owner can write into the chat
12e2a3b
@Hocuri
feat: Rename vb-request-v2 -> vb-request-with-auth
5e2fdd1 
Turns out that Alice reacts to a request-v2 message in exactly the same
way as to a request-with-auth message. So, no need to distinguish here.
@Hocuri
feat: Make reacting to v2 invites generic over the type of the invite…
bfedba9 
… (contact/group/broadcast)
@Hocuri
bench: Improve benchmark_decrypting.rs benchmark
49f1b37
@Hocuri
refactor: Remove small code duplication
dda2a57
@Hocuri
resolve some small TODOs
39396ab
@Hocuri
Resolve some small TODOs
fd2847b
@Hocuri
feat: Sync Alice's verification on Bob's side
0b365d3
@Hocuri Hocuri changed the title [WIP] Symmetrically encrypted broadcast channels [WIP] Symmetric encryption and QR codes for broadcast channels Aug 12, 2025
@Hocuri Hocuri changed the title [WIP] Symmetric encryption and QR codes for broadcast channels [WIP] QR codes and symmetric encryption for broadcast channels Aug 12, 2025
@Hocuri Hocuri force-pushed the hoc/channels-encryption-only-qrcodes branch from e4e7a36 to 0b365d3 Compare August 12, 2025 14:01
@Hocuri Hocuri mentioned this pull request Aug 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Hocuri