Skip to content

cleanup time format property for garden #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kart2bc
Copy link
Contributor

@kart2bc kart2bc commented Jun 27, 2025

Please take a moment to review the questions before submitting the PR

🚫 We only accept PRs to develop branch. If this is an exception, please specify why 🚫

WHAT is this change about?

Removing the obsolete logging timestamp format property

What customer problem is being addressed? Use customer persona to define the problem e.g. Alana is unable to...

Alana no need to manage the logging timestamp format property as it is always rfc3339.

Please provide any contextual information.

cloudfoundry/garden-runc-release#377

Has a cf-deployment including this change passed cf-acceptance-tests?

  • YES
  • NO

Does this PR introduce a breaking change? Please take a moment to read through the examples before answering the question.

  • YES - please choose the category from below. Feel free to provide additional details.
  • NO

How should this change be described in cf-deployment release notes?

Alana no need to manage the logging timestamp format property as it is always rfc3339.

Does this PR introduce a new BOSH release into the base cf-deployment.yml manifest or any ops-files?

  • YES - please specify
  • NO

Does this PR make a change to an experimental or GA'd feature/component?

  • experimental feature/component
  • GA'd feature/component

Please provide Acceptance Criteria for this change?

NA. Just removing the logging timestamp format property

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

Tag your pair, your PM, and/or team!

@cloudfoundry/wg-app-runtime-platform-diego-approvers

@kart2bc kart2bc changed the base branch from main to develop August 4, 2025 14:29
@kart2bc kart2bc marked this pull request as ready for review August 12, 2025 14:56
@dimivel dimivel requested review from a team August 14, 2025 14:30
@kart2bc
Copy link
Contributor Author

kart2bc commented Aug 14, 2025

concourse-ci/base-branch-should-be-develop - though i am pointing to the right branch(develop), it fails.

@oliver-heinrich
Copy link

Hi @iaftab-alam, can you review? Looks ok if logging timestamp format property is always rfc3339. Do we have/need tests?

@chombium
Copy link
Contributor

This is the relevant PR in the garden-runc-release release which removes the property in the job spec.

@kart2bc please link the relevant PRs for the corresponding releases next time, so that everyone knows what the change is about.

@oliver-heinrich, @dimivel do we also need an approval from wg-app-runtime-platform-garden-containers-approvers to check this?

@kart2bc
Copy link
Contributor Author

kart2bc commented Aug 18, 2025

This is the relevant PR in the garden-runc-release release which removes the property in the job spec.

@kart2bc please link the relevant PRs for the corresponding releases next time, so that everyone knows what the change is about.

@oliver-heinrich, @dimivel do we also need an approval from wg-app-runtime-platform-garden-containers-approvers to check this?

@chombium I had included the PR info at the contextual information section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants