Skip to content

pcr: reorder time series dashboards #150725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alicia-l2
Copy link

@alicia-l2 alicia-l2 commented Jul 24, 2025

Swapped order of Replication Lag and Logical Bytes graphs in Physical Cluster Replication DB Console

Fixes: #147621
Release note: none

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link

cockroachlabs-cla-agent bot commented Jul 24, 2025

CLA assistant check
All committers have signed the CLA.

@msbutler
Copy link
Collaborator

@alicia-l2 nice! a few nits:

  • 2 general conventions for commit/PR/issue titles are: 1) describe an action; 2) prefix with code area . Instead of PCR DB Console Metrics, i would say something likepcr: reorder time series dashboards

  • The commit body should be:

 Fixes #github issue number
 
 Release note: none

for more on commit message guidelines https://cockroachlabs.atlassian.net/wiki/spaces/CRDB/pages/73072807/Git+Commit+Messages

@alicia-l2 alicia-l2 changed the title PCR DB Console Metrics Dashboards pcr: reorder time series dashboards Jul 25, 2025
@alicia-l2
Copy link
Author

@msbutler done, what happens next?

@msbutler msbutler self-requested a review July 25, 2025 16:47
@msbutler
Copy link
Collaborator

@alicia-l2 some next steps:

  • make sure the commit message looks identical to the pr text on github. you can do this via git commit --amend
  • mark this PR as ready for review so i can approve it!
image

@alicia-l2 alicia-l2 marked this pull request as ready for review July 25, 2025 19:55
@alicia-l2 alicia-l2 requested a review from a team as a code owner July 25, 2025 19:55
@alicia-l2 alicia-l2 requested review from dhartunian and removed request for a team July 25, 2025 19:55
… Cluster Replication DB Console

Fixes: cockroachdb#147621
Release note: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

switch order of PCR dashboards on DB console
3 participants