-
Notifications
You must be signed in to change notification settings - Fork 472
Add documentation for new backup and restore cloud API endpoints #20012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Files changed:
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
❌ Deploy Preview for cockroachdb-docs failed. Why did it fail? →
|
❌ Deploy Preview for cockroachdb-docs failed. Why did it fail? →
|
❌ Deploy Preview for cockroachdb-docs failed. Why did it fail? →
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you be able to fix the first link for "Managed backups" in the following section? https://deploy-preview-20012--cockroachdb-docs.netlify.app/docs/cockroachcloud/backup-and-restore-overview#managed-backups
It currently points to the same page. Please make it point to https://deploy-preview-20012--cockroachdb-docs.netlify.app/docs/cockroachcloud/managed-backups
I just realized that it is in an include file as the intro paragraph for the managed-backup pages.
lgtm pending suggestions (mostly nits about verb tense)
src/current/_includes/cockroachcloud/backups/cloud-api-restore-endpoint.md
Outdated
Show resolved
Hide resolved
src/current/_includes/cockroachcloud/backups/cloud-api-restore-endpoint.md
Outdated
Show resolved
Hide resolved
src/current/_includes/cockroachcloud/backups/cloud-api-restore-endpoint.md
Outdated
Show resolved
Hide resolved
src/current/_includes/cockroachcloud/backups/cloud-api-restore-endpoint.md
Outdated
Show resolved
Hide resolved
src/current/_includes/cockroachcloud/backups/cloud-api-restore-endpoint.md
Outdated
Show resolved
Hide resolved
src/current/_includes/cockroachcloud/backups/cloud-api-restore-endpoint.md
Outdated
Show resolved
Hide resolved
src/current/_includes/cockroachcloud/backups/cloud-api-restore-endpoint.md
Outdated
Show resolved
Hide resolved
src/current/_includes/cockroachcloud/backups/cloud-api-restore-endpoint.md
Outdated
Show resolved
Hide resolved
src/current/_includes/cockroachcloud/backups/cloud-api-restore-endpoint.md
Outdated
Show resolved
Hide resolved
src/current/_includes/cockroachcloud/backups/cloud-api-backup-view.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - left a few notes!
"status": "PENDING", | ||
"created_at": "2025-07-25T16:45:14.064208710Z", | ||
"type": "CLUSTER", | ||
"completion_percent": 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit - can we say 100 as that would be 100% completed aka successful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@linhcrl I believe on Intrusion we return a float64 (i.e. 1
instead of 100
). Does Console update this to a percentage value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, we keep it a float between 0 and 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be call fraction_completed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we purposely renamed it for the CC API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be read as the JSON returned immediately to the POST request, wouldn't it show the lowest completion percent?
src/current/_includes/cockroachcloud/backups/cloud-api-restore-endpoint.md
Outdated
Show resolved
Hide resolved
src/current/_includes/cockroachcloud/backups/cloud-api-restore-endpoint.md
Outdated
Show resolved
Hide resolved
src/current/_includes/cockroachcloud/backups/cloud-api-restore-endpoint.md
Outdated
Show resolved
Hide resolved
src/current/_includes/cockroachcloud/backups/cloud-api-restore-endpoint.md
Outdated
Show resolved
Hide resolved
src/current/_includes/cockroachcloud/backups/cloud-api-restore-endpoint.md
Outdated
Show resolved
Hide resolved
"status": "PENDING", | ||
"created_at": "2025-07-25T16:45:14.064208710Z", | ||
"type": "CLUSTER", | ||
"completion_percent": 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@linhcrl I believe on Intrusion we return a float64 (i.e. 1
instead of 100
). Does Console update this to a percentage value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments. Let me know if you have any questions. Thanks for putting this together!
src/current/_includes/cockroachcloud/backups/cloud-api-backup-view.md
Outdated
Show resolved
Hide resolved
src/current/_includes/cockroachcloud/backups/cloud-api-restore-endpoint.md
Outdated
Show resolved
Hide resolved
src/current/_includes/cockroachcloud/backups/cloud-api-restore-endpoint.md
Outdated
Show resolved
Hide resolved
src/current/_includes/cockroachcloud/backups/cloud-api-restore-endpoint.md
Outdated
Show resolved
Hide resolved
"status": "PENDING", | ||
"created_at": "2025-07-25T16:45:14.064208710Z", | ||
"type": "CLUSTER", | ||
"completion_percent": 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, we keep it a float between 0 and 1
src/current/_includes/cockroachcloud/backups/cloud-api-restore-endpoint.md
Show resolved
Hide resolved
src/current/_includes/cockroachcloud/backups/cloud-api-restore-endpoint.md
Outdated
Show resolved
Hide resolved
~~~ | ||
{% endif %} | ||
|
||
You can specify additional options for the restore operation in the `restore_opts` object. For more information, see the [API endpoint documentation](https://www.cockroachlabs.com/docs/api/cloud/v1#get-/api/v1/clusters/-cluster_id-/restores-config). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this document?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put this in as a placeholder for the actual API reference docs URL. If it'll be different when published, please let me know and I can update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, please tag me when the param document is available. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be part of the proto? Since this link goes out to the API documentation, it's not going to docs that I'm writing.
src/current/_includes/cockroachcloud/backups/cloud-api-restore-endpoint.md
Outdated
Show resolved
Hide resolved
52ac555
to
f99a427
Compare
Fixes DOC-11599
Add task-oriented guidance to our docs around using the cloud API to:
Opted to break out our existing include(s) for human readability due to different functionality between Cloud plans