-
Notifications
You must be signed in to change notification settings - Fork 472
Document create_table_with_schema_locked
setting
#20013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
Files changed:
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
ba13a60
to
1c66473
Compare
Fixes DOC-11544 Summary of changes: - Add `create_table_with_schema_locked` session var docs, with a link to the `schema_locked` table storage parameter. - Since table storage parameters can be added during `CREATE TABLE`, and the list of storage params is in an include file, we share the include file into the `CREATE TABLE` docs as well (they were already in `ALTER TABLE` docs).
1c66473
to
491155c
Compare
fqazi
approved these changes
Jul 29, 2025
taroface
approved these changes
Jul 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one optional suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Summary of changes:
Add
create_table_with_schema_locked
session var docs, with a link tothe
schema_locked
table storage parameter.Since table storage parameters can be added during
CREATE TABLE
, andthe list of storage params is in an include file, we share the include
file into the
CREATE TABLE
docs as well (they were already inALTER TABLE
docs).