Avoid failing the test for a given threshold but yet generating the difference image #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 26, 2020 00:10
…a given threshold but yet generating the difference image
|
@puneet0191 could you please review this and deliver in the next release too? |
|
Yes for sure, I will include it in 1.9.1 release |
puneet0191
approved these changes
Apr 27, 2020
puneet0191
added a commit
that referenced
this pull request
May 16, 2020
* Issue #60 - Prepare all baselines of test by setting parameter in config (#65) Co-authored-by: Jonatas Kirsch <[email protected]> * Update Dependecies, Fix Fatal Error with mkdirp and Mac (#66) * Update Dependencies * Fix Error on Mac * Avoid failing the test for a given threshold but yet generating the difference image (#63) * Option bypassFailure allowing the user to avoid failing the test for a given threshold but yet generating the difference image * Renamed option to skipFailure Co-authored-by: Jonatas Kirsch <[email protected]> * feat(testcafe): add the support for testcafe (#62) * passing through output settings to resemble.js (#59) Co-authored-by: JANK Michael <[email protected]> * Issue 48 - Add custom assert message (#64) Co-authored-by: Jonatas Kirsch <[email protected]> Co-authored-by: Jonatas Kirsch <[email protected]> Co-authored-by: Jonatas Kirsch <[email protected]> Co-authored-by: Guillaume Camus <[email protected]> Co-authored-by: yankydoo <[email protected]> Co-authored-by: JANK Michael <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are scenarios where we want to see the differences but we do not want the pipeline fails with this threshold, e.g. the test with threshold 1 should not fail the pipeline but we want to see the differences anyway.
This branch adds a new option called "skipFailure". If "true" then the system generates the diff file but does not fail the test.