Skip to content

S3: slim down service implementation #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

S3: slim down service implementation #1

wants to merge 1 commit into from

Conversation

brynary
Copy link

@brynary brynary commented Jul 1, 2024

  • Use simple core API for duck-type compat with other clients
  • Support stubbing client responses for testing without S3 credentials or local mock
  • initialize: accept an existing client
  • initialize: accept arbitrary client args instead of a fixed, required set
  • download: use native get_object streaming, no need to implement range requests
  • exists?: use head_object (which returns immediately) rather than waiting for existence

@jeremy
S3: slim down service implementation
30edeab 
* Use simple core API for duck-type compat with other clients
* Support stubbing client responses for testing without S3 credentials or local mock
* initialize: accept an existing client
* initialize: accept arbitrary client args instead of a fixed, required set
* download: use native get_object streaming, no need to implement range requests
* exists?: use head_object (which returns immediately) rather than waiting for existence
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brynary @jeremy