Skip to content
This repository was archived by the owner on Jul 19, 2025. It is now read-only.

Address FileThreadPool race condition #69

Merged
merged 1 commit into from
Jan 4, 2016
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/cc/engine/analyzers/file_thread_pool.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,11 @@ def initialize(files, concurrency: DEFAULT_CONCURRENCY)

def run(&block)
queue = build_queue
lock = Mutex.new

@workers = thread_count.times.map do
Thread.new do
while !queue.empty? && (item = queue.pop(true))
while (item = next_item(queue, lock))
yield item
end
end
Expand All @@ -32,6 +33,10 @@ def join

attr_reader :files, :concurrency, :workers

def next_item(queue, lock)
lock.synchronize { queue.pop(true) unless queue.empty? }
end

def build_queue
Queue.new.tap do |queue|
files.each do |file|
Expand Down