Skip to content
This repository was archived by the owner on Jul 19, 2025. It is now read-only.

PHP Parser: handle INF/NaN nodes #71

Merged
merged 1 commit into from
Jan 4, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions spec/cc/engine/analyzers/php/main_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,31 @@
expect(result).to match "\"type\":\"issue\""
end

it "handles INF & NAN constants" do
create_source_file("foo.php", <<-EOPHP)
<?php
function f1($name) {
// the php-parser lib turns this into INF, but writing INF directly gets emitted differently
if (empty($name)) {
return 646e444;
} else {
return 0;
}
}

function f2($name) {
if (empty($name)) {
return 646e444;
} else {
return 0;
}
}
EOPHP

result = run_engine(engine_conf).strip
expect(result).to match "\"type\":\"issue\""
end

it "skips unparsable files" do
create_source_file("foo.php", <<-EOPHP)
<?php blorb &; "fee
Expand Down
6 changes: 5 additions & 1 deletion vendor/php-parser/lib/PhpParser/Serializer/JSON.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,11 @@ protected function _serialize($node) {
}

foreach ($node as $name => $subNode) {
if (is_string($subNode)) {
if (INF === $subNode) {
$doc[$name] = "_PHP:CONST:INF";
} elseif (NaN === $subNode) {
$doc[$name] = "_PHP:CONST:NaN";
} elseif (is_string($subNode)) {
$doc[$name] = utf8_encode($subNode);
} elseif (is_int($subNode)) {
$doc[$name] = $subNode;
Expand Down