Report issue for each occurrence of duplication #83
Conversation
| description = "#{check_name} found in #{occurrences} other location" | ||
| description += "s" if occurrences > 1 | ||
| description = "#{check_name} found in #{(other_sexps.length)} other location" | ||
| description += "s" if other_sexps.length > 1 |
There was a problem hiding this comment.
Now that we preserved #occurrences, I think you can revert this too.
ABaldwinHunter
force-pushed
the
abh-pb-multi-issues
branch
6 times, most recently
from
0e25163 to
b0e24ae
Compare
|
@pbrisbin Ready for re-review! |
|
Removed any drive-by changes and added spec. |
ABaldwinHunter
force-pushed
the
abh-pb-multi-issues
branch
from
b0e24ae to
93e586c
Compare
| @@ -93,6 +95,7 @@ | |||
|
|
|||
| result = run_engine(engine_conf).strip | |||
| issues = result.split("\0") | |||
|
|
|||
This change fixes a bug in which we reported only the first occurrence (or sexp) of duplicated code in a set, and dropped the rest. The others were included in other_locations but not reported as an independent issue.
ABaldwinHunter
force-pushed
the
abh-pb-multi-issues
branch
from
93e586c to
2c7162b
Compare
|
This LGTM. I fully expect this to have a (potentially strong) impact on grades. We're taking what was a single thing representing N instances of duplication with X remediation_points and now reporting N things each with X remediation_points. This means the total remediation_points for the duplication will go from X to X*N. I'm fine with this, we'll discuss it and tune points and grades separately via a new PR, but it should be explained in the ChangeLog. |
|
👍 The mass and point algorithm changes coming on the heels of this PR will also impact grades. The overall impact may be smaller grade impact on more files. |
Report issue for each occurrence of duplication
This change fixes a bug in which we reported only the first occurrence
(or sexp) of duplicated code in a set, and dropped the rest. The others
were included in other_locations but not reported as an independent issue.
@codeclimate/review
cc @pbrisbin
First step in breaking apart #78