Skip to content

Add pending spec for over-escaped multibyte source #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2016
Merged

Conversation

pbrisbin
Copy link
Contributor

@pbrisbin pbrisbin commented Feb 1, 2016

Some customers have code with escaped multibyte characters in regular
expressions. This causes the engine to error because File.read doubly-escapes
it, which fails to parse.

The escaping these customers have is not needed. They can remove their
backslash and all should work fine. That's what we're prescribing for now via
customer services, since all other options are too time-consuming.

Eventually, we would like to support this code as-is (as we do any realistic
source files customers may have) -- when/if we do, this spec will pass.

/cc @codeclimate/review

Some customers have code with escaped multibyte characters in regular
expressions. This causes the engine to error because File.read
doubly-escapes it, which fails to parse.

The escaping these customers have is not needed. They can remove their
backslash and all should work fine. That's what we're prescribing for
now via customer services, since all other options are too
time-consuming.

Eventually, we would like to support this code as-is (as we do any
realistic source files customers may have) -- when/if we do, this spec
will pass.
@pbrisbin
Copy link
Contributor Author

pbrisbin commented Feb 2, 2016

Ping @wfleming

@ABaldwinHunter
Copy link
Contributor

LGTM

pbrisbin added a commit that referenced this pull request Feb 2, 2016
Add pending spec for over-escaped multibyte source
@pbrisbin pbrisbin merged commit 5183658 into master Feb 2, 2016
@pbrisbin pbrisbin deleted the pb-multibyte branch February 2, 2016 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants