Display language doesn't persist in code-server v3.11.0 running in Docker container when installing from CLI

[aleleba]

OS/Web Information

• Web Browser:
• Local OS:
• Remote OS:
• Remote Architecture:
• code-server --version:
  Version 3.11.0 of Code-Server

Steps to Reproduce

1. Add file "argv.json" to "/home/coder/.local/share/code-server/User/"
2. Reload window
3. Languague change
4. Code of argv.json:

{
    "locale": "es"
}

Expected

Change Languague Display

Actual

Not Change Language Display

Logs

Screenshot

Notes

This issue can be reproduced in VS Code: Yes/No

[jsjoeio]

I was able to successfully reproduce this on macOS + Chrome and code-server 3.10.0

[jsjoeio]

However, you can change the display language if you do the following:

1. Open Command Palette
2. Search for "Configure Display Language"
3. Click "Install additional Languages"
4. Select language pack
5. Reload

Screenshot

And, if you restart code-server the language pack is installed and we set the locale in argsv.json so it persists!

@aleleba can you please double-check that you have the language pack extension installed?

[aleleba]

@jsjoeio, Yes I can confirm that I install the language pack. Currently I install the Spanish Language package directly with a command in my Dockerfile.

What happens in the previous versions of code-server is that when entering for the first time it already opened the Spanish language by default.

I just tried uninstalling and installing the package again, restarted the window and changed the language.

In the same way, I would like the language to be preloaded as before, so that if the Docker container falls, it takes the language configuration at once.

I am attaching the docker docker command I use in the Dockerfile:

RUN code-server --extensions-dir ~/.local/share/code-server/extensions/ --install-extension ms-ceintl.vscode-language-pack-es

I really appreciate the follow-up and the help.

[jsjoeio]

Ah okay, thank you for all the details. So here's a screenshot of my running that command locally (not using Docker):

Hmm...now this is interesting... When I look inside /Users/jp/.local/share/code-server/User, I see an argsv.json and argv.json 🤔

I'll keep both and restart code-server.

It's in Spanish, as expected.

According to VS Code's docs, argv.json is the expected filename to keep the locale.

Let's delete the argsv.json, restart code-server and see what happens. Still in Spanish so that wasn't an issue. (probably a typo from me)

Well, I'm a bit stumped. It feels like this is specific to how code-server is loading/running in your Docker environment. Maybe @code-asher has some insight.

[aleleba]

@jsjoeio, @code-asher, I started to see the changes from version 3.9.3 to version 3.10.0, to see if I can help to find the error and I could observe this change: https://github.com/cdr/code-server/pull/3250/files

I think instead of placing:

yarn gulp compile-build compile-extensions-build

You have to place:

yarn gulp compile-build && yarn gulp compile-extensions-build

To stand in a line.

I don't use yarn and gulp, and I'm not an expert in bash, so I don't really know if that is the case.

I hope to help a little

[jsjoeio]

Maybe @oxy might have some insight too.

[code-asher]

I was able to replicate with:

$ rm ~/.local/share/code-server -r
$ code-server --install-extension ms-ceintl.vscode-language-pack-es
$ echo '{"locale":"es"}' > ~/.local/share/code-server/User/argv.json
$ code-server # Browse to localhost:8080

Strangely, I don't get the option to select es from the command palette either even though the extension is installed.

If I uninstall the extension and re-install then refresh everything works.

I think there is some language bundle generation that happens somewhere that isn't running when doing things in the CLI but is running when doing things through the UI.