Skip to content

Improve handshake to better match RFC #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2019
Merged

Improve handshake to better match RFC #177

merged 1 commit into from
Dec 6, 2019

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Dec 6, 2019

Closes #176
Closes #173

@nhooyr
Copy link
Contributor Author

nhooyr commented Dec 6, 2019

Please review @nerg4l

@nhooyr nhooyr merged commit 449143b into master Dec 6, 2019
@nhooyr nhooyr deleted the handshake-fixes branch December 6, 2019 20:05
@nhooyr
Copy link
Contributor Author

nhooyr commented Dec 6, 2019

Thanks @nerg4l

@nerg4l
Copy link

nerg4l commented Dec 6, 2019

Anytime @nhooyr . I will keep looking for improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sec-WebSocket-Version missing from response on handshake error Return HTTP 426 status code when appropriate
2 participants