Skip to content

Refactoring #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from
Closed

Refactoring #62

wants to merge 15 commits into from

Conversation

mpsido
Copy link
Contributor

@mpsido mpsido commented Dec 27, 2017

Big refactoring, changing code structure and merging it with the new features introduced in logDouble branch: #53

Copy link
Member

@lenzai lenzai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • a lot of changes off topic. Lack of discipline.
  • a lot of redundant noise in the diff. This is a bad habbit.
  • hiding loadDatabase is questionable, making the behaviour smarter and obscure. Making calls to search database .
  • it seems that addSimilarItems is broken. It should embrace the same style as searchDatabase with a callback.

Overall: a lot of noise and distraction , the main change is mostly different, not really better.

Copy link
Member

@lenzai lenzai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are the changes in app.js part of the fix? Or just a distraction?

Copy link
Member

@lenzai lenzai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearly this features is screaming for OOP

Here are the symptoms

  • adding global variables
  • adding extra arguments to functions.

@mpsido mpsido closed this Dec 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants