-
Notifications
You must be signed in to change notification settings - Fork 3
Refactoring #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- a lot of changes off topic. Lack of discipline.
- a lot of redundant noise in the diff. This is a bad habbit.
- hiding loadDatabase is questionable, making the behaviour smarter and obscure. Making calls to search database .
- it seems that addSimilarItems is broken. It should embrace the same style as searchDatabase with a callback.
Overall: a lot of noise and distraction , the main change is mostly different, not really better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are the changes in app.js part of the fix? Or just a distraction?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clearly this features is screaming for OOP
Here are the symptoms
- adding global variables
- adding extra arguments to functions.
Big refactoring, changing code structure and merging it with the new features introduced in logDouble branch: #53