Skip to content

Added a scroll to top component #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 8, 2020

Conversation

JanviMahajan14
Copy link
Contributor

I have updated the website with a scroll to top button.

@JanviMahajan14
Copy link
Contributor Author

Please review @vaibhavdaren @Rupeshiya @jaskirat2000

Copy link
Member

@Rupeshiya Rupeshiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JanviMahajan14 From next time when you do some changes in UI please add the screenshot.
Here everything is good in desktop view
desktop

But a small issue in mobile view, please have a look at it
mob

Nice work @JanviMahajan14

@JanviMahajan14
Copy link
Contributor Author

Thanks @Rupeshiya . I have fixed the mobile view issue.
Screenshot from 2020-02-04 02-02-33

Copy link
Member

@Rupeshiya Rupeshiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work @JanviMahajan14 .
@ayushnagar123 Please merge it.

@ayushnagar123 ayushnagar123 merged commit eaa8c54 into codeuino:development Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants