Fixes #196- Fetching articles from Medium #197
Conversation
|
Hi @AuraOfDivinity this looks good to me. So now it should automatically showcase all the latest blogs from the medium. I am tagging @devesh-verma and @ayushnagar123 to have their point of view what they think about it. Cc @Rupeshiya |
jaskiratsingh2000
requested review from
Rupeshiya,
ayushnagar123 and
devesh-verma
There was a problem hiding this comment.
@AuraOfDivinity Everything else in implementation looks good to me.
Also please improve the UI as suggested by @jaskirat2000 and instead of rendering all the blogs in home page, render at max 3-posts in home page and give a "Read more" button at last which will redirect to the blogs component where all the blogs should be rendered one by one and on clicking any one of the blog it will render single blog contents.
cc @devesh-verma @vaibhavdaren please review.
|
|
||
| componentDidMount() { | ||
| let activities = []; | ||
| fetch("https://medium-article-fetcher.herokuapp.com/posts", { |
There was a problem hiding this comment.
@AuraOfDivinity I don't think this will be best solution for implementing this feature, you are making the whole functionality dependent on the other codebase which is not owned by the org.
We should find other workaround to implement this functionality by keeping this in mind that we don't want to increace the dependencies.
There was a problem hiding this comment.
api server we will find a workaround in sometime.
|
@jaskirat2000 @Rupeshiya Thanks for the feedback. I have made the requested changes. @Rupeshiya Totally agree with you on your concern of data fetching part being dependant on another codebase not owned by the org. Do you have any suggestions to resolve this issue? |
There was a problem hiding this comment.
@AuraOfDivinity You are showing first three posts in the home page that's good, also add a "Read more" button just below the three posts row which will redirect to the component where all the posts will be rendered similar as you shown in the home page but on clicking the single post of medium the single post content will be rendered .
Nice work @AuraOfDivinity.
cc @vaibhavdaren @jaskirat2000 please update him with your view
|
I agree on above. Go ahead. 😀✌ |
|
@jaskirat2000 @Rupeshiya I have made the requested changes. Please have a look and let me know if any more changes are required.
|
|
The modal that opens on read more looks funny. 🗡 |
|
I think we can have a iframe in popup modal or we can go with redirect. |
|
yes @vaibhavdaren we can go with redirect option. But what about this #197 (comment) |
|
Lets Go with redirect . |
|
@vaibhavdaren I am asking for the solution of #197 (comment) |
|
I have removed the modal as requested. The users will be redirected medium now. @Rupeshiya is asking whether or not it is a good idea to continue being dependant on the simple app I created to fetch the data about the medium articles. I would love to hear your opinion on this @vaibhavdaren |
|
@Rupeshiya @AuraOfDivinity |
|
@vaibhavdaren Is anything else required from my end with regard to this issue? |
**Fixes #196 **
The medium API is write only and doesn't offer any api endpoint to fetch posts of a given user. The only endpoint that does the job (i.e user/{userID}/publications) requires an auth token(which can be obtained by emailing medium) and returns all the publications including publications that the user has written, is editing and subscribed to . The returned response doesn't offer a way to distinguish posts between the ones the user has written and the ones the user has subscribed to. (https://github.com/Medium/medium-api-docs)
The workaround for this is to run a separate small webserver to fetch the RSS feed of a given user and converting it to a JSON response. I created a simple server to do the above task here.
Screenshots
@jaskirat2000 Would like to know your thoughts on this.