Skip to content

modified threader to be more cpu efficient #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2018
Merged

modified threader to be more cpu efficient #1

merged 1 commit into from
Oct 26, 2018

Conversation

Charcol
Copy link

@Charcol Charcol commented Oct 26, 2018

Instead of the while loop waiting for a worker to become available then assigning a task, in this structure the workers request tasks when they're free. The original while loop constantly querying the worker queue would cause the python interpreter to lock, delaying the workers going back to the ready pool. So on larger tasks queues with more threads, this would be faster :)

@hakluke
Copy link
Collaborator

hakluke commented Oct 26, 2018 via email

@codingo
Copy link
Owner

codingo commented Oct 26, 2018

Makes a lot of sense, thank-you! Going to merge on presumption of testing being done since proj isn't public yet, and will do testing of my own this evening.

@codingo codingo added the enhancement New feature or request label Oct 26, 2018
@codingo codingo merged commit ba2156a into master Oct 26, 2018
@codingo codingo deleted the threader branch January 7, 2019 02:18
codingo pushed a commit that referenced this pull request Apr 30, 2019
Update task runner to allow multi-threading on OSX
codingo pushed a commit that referenced this pull request Apr 30, 2019
Fixed case-sensitivity on subprocess.call()
codingo pushed a commit that referenced this pull request Aug 16, 2019
Fix arguments.output bug introduced in #57
codingo pushed a commit that referenced this pull request Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants