Skip to content

test(changelog): ensure error on missing changelog template filename #1557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v4-9-0-test
Choose a base branch
from

Conversation

ongdisheng
Copy link

@ongdisheng ongdisheng commented Jul 6, 2025

Description

This PR adds a test to ensure the _export_template method raises a NotAllowed exception when the changelog template has no filename.

Related Code Fix PR: #1550
Close #1503

Checklist

Code Changes

  • Add test cases to all the changes you introduce

Copy link

codecov bot commented Jul 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v4-9-0-test@05c1722). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             v4-9-0-test    #1557   +/-   ##
==============================================
  Coverage               ?   98.02%           
==============================================
  Files                  ?       58           
  Lines                  ?     2680           
  Branches               ?        0           
==============================================
  Hits                   ?     2627           
  Misses                 ?       53           
  Partials               ?        0           
Flag Coverage Δ
unittests 98.02% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ongdisheng ongdisheng marked this pull request as ready for review July 6, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant