Skip to content

fix(commit): attach user info to backup for permission denied issue #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

SHAQ522
Copy link
Contributor

@SHAQ522 SHAQ522 commented Dec 16, 2020

For multi user situation, it may get fail

Permission denied: '/tmp/cz.commit.backup'

The reason is another user has already created a temp file with the same name.
So if one user create temp_file should attatch with $USER info to resolve permission issue

Description

attach user info to temp-file name when $USER is possible

Checklist

  • Add test cases to all the changes you introduce
  • Run ./script/format and ./script/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

create /tmp/cz.committom.backup

Steps to Test This Pull Request

Additional context

When multi users commit in the same machine shared backup will cause permission deny.
To resolve this issue, attach user info to the name of backup commit.
@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Merging #317 (aa2959d) into master (c09f377) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #317   +/-   ##
=======================================
  Coverage   97.17%   97.17%           
=======================================
  Files          35       35           
  Lines         991      991           
=======================================
  Hits          963      963           
  Misses         28       28           
Flag Coverage Δ
unittests 97.17% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/__version__.py 100.00% <100.00%> (ø)
commitizen/commands/commit.py 98.27% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c51a521...aa2959d. Read the comment docs.

@woile woile merged commit 88a5a1e into commitizen-tools:master Dec 16, 2020
@woile
Copy link
Member

woile commented Dec 16, 2020

Awesome, thanks! 🎉

@SHAQ522 SHAQ522 deleted the SHAQ522-fix-permission-deny-backup branch December 17, 2020 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants