Skip to content

Fix: JsonFileCache contains #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2024
Merged

Fix: JsonFileCache contains #35

merged 1 commit into from
Dec 2, 2024

Conversation

thekaveman
Copy link
Member

Need to implement __contains__ so that "key" in cache syntax works.

E.g. https://github.com/compilerla/compiler-admin/blob/main/compiler_admin/services/toggl.py#L32

if email in USER_INFO:
    USER_INFO[email].update(data)
else:
    USER_INFO[email] = data

@thekaveman thekaveman changed the title Fix: JsonFileCache Fix: JsonFileCache contains Dec 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  compiler_admin/services
  files.py
Project Total  

This report was generated by python-coverage-comment-action

@thekaveman thekaveman merged commit 986d9cc into main Dec 2, 2024
2 checks passed
@thekaveman thekaveman deleted the fix/files branch December 2, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thekaveman