Skip to content

[LWG motion 22] P2641R4 Checking if a union alternative is active #6348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 21, 2023
Merged

[LWG motion 22] P2641R4 Checking if a union alternative is active #6348

merged 2 commits into from
Jul 21, 2023

Conversation

burblebee
Copy link
Contributor

@burblebee burblebee commented Jun 23, 2023 •
edited by jensmaurer
Loading

@burblebee burblebee force-pushed the motions-2023-06-lwg-22 branch from e2c4b41 to 1318a44 Compare June 23, 2023 21:33
@burblebee burblebee marked this pull request as ready for review June 23, 2023 21:46
JohelEGP
JohelEGP approved these changes Jun 25, 2023
View reviewed changes
Copy link
Contributor

@JohelEGP JohelEGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using https://isocpp.org/files/papers/P2641R4.html.

frederick-vs-ja
frederick-vs-ja reviewed Jun 27, 2023
View reviewed changes
@jensmaurer jensmaurer added this to the post-2023-06 milestone Jun 27, 2023
@tkoeppe tkoeppe force-pushed the motions-2023-06-lwg-22 branch from 7c8fec3 to 82b56e8 Compare July 21, 2023 20:33
burblebee added 2 commits July 21, 2023 21:41
@burblebee @tkoeppe
P2641R4 Checking if a union alternative is active
0facada 
The feature test macro has been renamed from __cpp_lib_within_lifetime
to __cpp_lib_is_within_lifetime, which seems more appropriate and
follows existing practice.
@burblebee @tkoeppe
[meta.type.synop, meta.const.eval] Rewrite declarations using auto
6a8b155 
See #4822 for the general policy on when to use abbreviated function
template syntax.
@tkoeppe tkoeppe force-pushed the motions-2023-06-lwg-22 branch from 82b56e8 to 6a8b155 Compare July 21, 2023 20:41
@tkoeppe tkoeppe merged commit 4fba140 into main Jul 21, 2023
@jensmaurer jensmaurer deleted the motions-2023-06-lwg-22 branch November 12, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely left review comments

@tkoeppe tkoeppe tkoeppe left review comments

@frederick-vs-ja frederick-vs-ja frederick-vs-ja left review comments

@jensmaurer jensmaurer jensmaurer left review comments

@lprv lprv lprv left review comments

@JohelEGP JohelEGP JohelEGP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
post-2023-06
Development

Successfully merging this pull request may close these issues.

[2023-06 LWG Motion 22] P2641R4 Checking if a union alternative is active P2641 R4 Checking if a union alternative is active
7 participants
@burblebee @jwakely @tkoeppe @JohelEGP @frederick-vs-ja @jensmaurer @lprv