P2079R10 Parallel scheduler #8033
Open
+443
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensmaurer
force-pushed
the
motions-2025-06-lwg-23
branch
from
461e878 to
606e6a5
Compare
Eisenwave
requested changes
Jul 10, 2025
| \item% | ||
| when \tcode{std::execution::get_parallel_scheduler} is called and | ||
| \tcode{std::execution::system_context_replace\-ability::query_parallel_scheduler_backend()} | ||
| returns a null pointer value\iref{exec.par.scheduler}. |
There was a problem hiding this comment.
The paper says
returns
nullptr
Seems like a fixup commit is needed, assuming this is purely editorial.
There was a problem hiding this comment.
This change from the paper's wording is intentional, you can't return the keyword "nullptr" (as seen by the caller).
Comment on lines
+5835
to
+5836
| calls \tcode{terminate}\iref{except.terminate}. | ||
| Otherwise, returns a \tcode{parallel_scheduler} object |
There was a problem hiding this comment.
Note that the paper originally said "terminate()" and "an parallel_scheduler" here (which are wrong and should be fixed, but still, it's all in one commit).
jensmaurer
force-pushed
the
motions-2025-06-lwg-23
branch
from
27f9ba3 to
dceb6b2
Compare
Eisenwave
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7960
Fixes cplusplus/papers#806