Skip to content

Suggesting for using is_copy_constructible_v in copy constructor #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: next
Choose a base branch
from
Open

Suggesting for using is_copy_constructible_v in copy constructor #1180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7489f40
Suggesting for is_copy_constructible_v in copy constructor
Jul 13, 2025
1956206
final fix of fast_io::vector
Jul 28, 2025
3c2a52b
Remove some abstract const rvalue ref
Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/0039.gen_win32_mangling/arm-windows-msvc.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ inline auto gen_pragmas(char8_t const *asmpath, ::fast_io::vector<::fast_io::u8s
bool is_win32_symbols{true};
::std::size_t symbols_index{};
auto asmfile = ::fast_io::native_file_loader{::fast_io::mnp::os_c_str(asmpath)};
auto const &&asmfile_size = asmfile.size();
auto const asmfile_size = asmfile.size();
for (::std::size_t i{}; i < asmfile_size; ++i)
{
if (asmfile[i + 0] == u8'm' && asmfile[i + 1] == u8'o' && asmfile[i + 2] == u8'v' && asmfile[i + 3] == u8'w')
Expand Down
2 changes: 1 addition & 1 deletion examples/0039.gen_win32_mangling/arm64ec-windows-msvc.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ inline auto gen_pragmas(char8_t const *asmpath, ::fast_io::vector<::fast_io::u8s
bool is_win32_symbols{true};
::std::size_t symbols_index{};
auto asmfile = ::fast_io::native_file_loader{::fast_io::mnp::os_c_str(asmpath)};
auto const &&asmfile_size = asmfile.size();
auto const asmfile_size = asmfile.size();
for (::std::size_t i{}; i < asmfile_size; ++i)
{
while (asmfile[i] == u8'\t' || asmfile[i] == u8' ' || asmfile[i] == u8'\n')
Expand Down
2 changes: 1 addition & 1 deletion examples/0039.gen_win32_mangling/common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ inline ::fast_io::vector<::fast_io::u8string> parse_symbols(char8_t const *path)
::fast_io::vector<::fast_io::u8string> result;
// TODO native_file_loader do not suppport ::fast_io::string_view
::fast_io::native_file_loader symbols_loader{::fast_io::mnp::os_c_str(path)};
auto const &&symbols_loader_size = symbols_loader.size();
auto const symbols_loader_size = symbols_loader.size();
for (::std::size_t i{}; i < symbols_loader_size; ++i)
{
::fast_io::u8string tmp{};
Expand Down
4 changes: 2 additions & 2 deletions examples/0039.gen_win32_mangling/i686-windows-msvc.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ inline auto parse_symbols(char8_t const *path)
::fast_io::vector<::fast_io::u8string> result;
// TODO native_file_loader do not suppport ::fast_io::string_view
::fast_io::native_file_loader symbols_loader{::fast_io::mnp::os_c_str(path)};
auto const &&symbols_loader_size = symbols_loader.size();
auto const symbols_loader_size = symbols_loader.size();
for (::std::size_t i{}; i < symbols_loader_size; ++i)
{
::fast_io::u8string tmp{};
Expand All @@ -35,7 +35,7 @@ inline auto gen_pragmas(char8_t const *asmpath, ::fast_io::vector<::fast_io::u8s
bool is_win32_symbols{true};
::std::size_t symbols_index{};
auto asmfile = ::fast_io::native_file_loader{::fast_io::mnp::os_c_str(asmpath)};
auto const &&asmfile_size = asmfile.size();
auto const asmfile_size = asmfile.size();
for (::std::size_t i{}; i < asmfile_size; ++i)
{
if (asmfile[i] == u8'c' && asmfile[i + 1] == u8'a' && asmfile[i + 2] == u8'l' && asmfile[i + 3] == u8'l' && asmfile[i + 4] == u8'l')
Expand Down
6 changes: 3 additions & 3 deletions examples/0039.gen_win32_mangling/prebuild.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ inline auto gen_apis(
{
::fast_io::u8string main_body{};
function_declaration.append(::fast_io::u8concat_fast_io(u8"namespace ", prefix, u8" {\n"));
auto const &&header_size = context.size();
auto const header_size = context.size();
for (::std::size_t i{}; i < header_size; ++i)
{
// FAST_IO_DLLIMPORT
Expand Down Expand Up @@ -189,8 +189,8 @@ int main(int argc, char *const *const argv)

::fast_io::native_mkdirat(::fast_io::at_fdcwd(), "build");

auto const &&nt_header = ::fast_io::native_file_loader{"../../include/fast_io_hosted/platforms/nt/nt_api.h"};
auto const &&win32_header = ::fast_io::native_file_loader{"../../include/fast_io_hosted/platforms/win32/apis.h"};
auto const nt_header = ::fast_io::native_file_loader{"../../include/fast_io_hosted/platforms/nt/nt_api.h"};
auto const win32_header = ::fast_io::native_file_loader{"../../include/fast_io_hosted/platforms/win32/apis.h"};

::fast_io::u8string win32_declaration{}, nt_declaration{}, win32_symbols{}, nt_symbols{};
// process win32 apis.h
Expand Down
2 changes: 1 addition & 1 deletion examples/0039.gen_win32_mangling/x86_64-windows-msvc.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ inline auto gen_pragmas(char8_t const *asmpath, ::fast_io::vector<::fast_io::u8s
bool is_win32_symbols{true};
::std::size_t symbols_index{};
auto asmfile = ::fast_io::native_file_loader{::fast_io::mnp::os_c_str(asmpath)};
auto const &&asmfile_size = asmfile.size();
auto const asmfile_size = asmfile.size();
for (::std::size_t i{}; i < asmfile_size; ++i)
{
if (asmfile[i] == u8'c' && asmfile[i + 1] == u8'a' && asmfile[i + 2] == u8'l' && asmfile[i + 3] == u8'l' && asmfile[i + 4] == u8'q')
Expand Down
4 changes: 2 additions & 2 deletions include/fast_io_dsal/impl/vector.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ struct vector_internal

} // namespace details

template <::std::movable T, typename allocator>
template <typename T, typename allocator>
class vector FAST_IO_TRIVIALLY_RELOCATABLE_IF_ELIGIBLE
{
public:
Expand Down Expand Up @@ -397,7 +397,7 @@ class vector FAST_IO_TRIVIALLY_RELOCATABLE_IF_ELIGIBLE
}

inline constexpr vector(vector const &vec)
requires(::std::copyable<value_type>)
requires(::std::is_copy_constructible_v<value_type>)
{
std::size_t const vecsize{static_cast<std::size_t>(vec.imp.curr_ptr - vec.imp.begin_ptr)};
if (vecsize == 0)
Expand Down