Fix scrollbar width for main body text #1716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
approved these changes
Jun 13, 2018
| @@ -72,6 +72,7 @@ main { | |||
| ::-webkit-scrollbar-thumb{ background-color: #CCC; } | |||
| ::-webkit-scrollbar-thumb:hover{ background-color: #CCC; } | |||
| ::-webkit-scrollbar{ width: 4px; } | |||
| .main-content::-webkit-scrollbar{ width: 8px; } | |||
There was a problem hiding this comment.
lgtm, but what do things look like if you just remove all the explicit webkit-scrollbar selectors?
There was a problem hiding this comment.
All of the scrollbars revert to browser defaults:
I suspect that the reason we're using webkit scrollbars is that the dartlang.org website tends to use them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1711.
Increases the width of the main body scrollbar to 8 pixels, making it easier to use in cases where there's no right-column sidebar, and just generally easier to see.
Other scrollbars remain unaffected:
While platforms/browsers that do not have a border around the browser (e.g. Chrome on Linux) have a wide enough scrollbar that Chrome does not prevent you from using most of it: