Skip to content

Add a travis bot for testing dartdoc against SDK head analyzer #1777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 4, 2018

Conversation

jcollins-g
Copy link
Contributor

This will make it a little easier/faster to detect breaking changes in the SDK before they start impacting dartdoc, and verify that new changes to dartdoc will still work with the head SDK.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Oct 3, 2018
@devoncarew
Copy link
Member

cc'ing @MichaelRFairhurst, who I believe also has a test-sdk-at-head bot (set up for the angulardart analysis plugin).

Copy link
Contributor

@MichaelRFairhurst MichaelRFairhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You may need/want to use depot_tools to ensure you can pull in all transitive dependencies (things like package:args) but then managing the .packages file becomes hacky. This LGTM assuming you don't need any such transitive deps

@jcollins-g
Copy link
Contributor Author

@MichaelRFairhurst Not a bad idea, that would cover the case for dartdoc running inside the SDK (which is a little different than what this does). Maybe in a future PR.

@jcollins-g jcollins-g merged commit 5f7bb18 into master Oct 4, 2018
@jcollins-g jcollins-g deleted the head-analyzer-testing branch October 4, 2018 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants