Skip to content

Implement covariant handling for dartdoc #1782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 5, 2018
Merged

Implement covariant handling for dartdoc #1782

merged 6 commits into from
Oct 5, 2018

Conversation

jcollins-g
Copy link
Contributor

Fixes #1424.

Implements covariant detection and handling for parameters and fields. Displays them properly in the parameter list for methods:
screenshot from 2018-10-04 14-39-04

... fixing the original bug:

screenshot from 2018-10-04 14-59-00

Also displays "covariant" as part of the feature list next to the one-line version of Field(Property) documentation:

screenshot from 2018-10-04 14-38-39

Including when the covariance of the field is established through a setter's parameter:

screenshot from 2018-10-04 14-39-56

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Oct 4, 2018
@jcollins-g jcollins-g requested review from pq and devoncarew October 4, 2018 22:00
Copy link
Member

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jcollins-g jcollins-g merged commit 4ad9268 into master Oct 5, 2018
@jcollins-g jcollins-g deleted the covariant branch October 5, 2018 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output generated for @covariant parameters is not correct
3 participants